Unified UWP/WinUI 3 Sample App #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple App Reduce duplication of image files and save space in repo (no functional change)
… files for main UserControl. Adds a Task to UWP project to rename namespaces and copy file over before build (added to gitignore) Adds Dependency Injection to WinUI 3 head to match UWP Centralizes AppService setup in shared project Fixes 'Pause shader' typo Brings missing error and vertical sync options to WinUI 3 sample app from Sergio0694#197 and Sergio0694#200.
|
Closing this, since I've now removed UWP support from main, and it'll only remain in the 2.2 branch for maintenance (since we use that in the Microsoft Store). Along with that, I've also removed the UWP sample app from main, so this PR doesn't apply anymore. Thank you though, and sorry for the delay! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the code for the UWP and WinUI 3 sample app heads in order to make them both run from a single source XAML/cs file. (It also consolidates the icon/app assets between the two using the shared project.)
This will reduce overhead and maintenance costs and make it easier to add features moving forward.
Some features like #197 and #200 were only added to the UWP head and missed from the WinUI 3 counterpart for instance.
No major functional changes have been made to the app or how it works; however, app services (from UWP) and the conditionalweaktable (from WinUI 3) are now in both apps; though app services is not enabled for WinUI 3.
Additional context
We use the existing shared project to do this as well as an msbuild task which rewrites the namespaces in the XAML file for UWP before the UWP project builds (these generated files are git ignored).
I did use a git move commit in order to preserve history, the overall GitHub diff isn't doing a good job of showing that. Reviewing some of the later commits on their own provides a better picture.
Related to issues #442 #162