Skip to content

ItemKey: Add ItemKey::MusicBrainzReleaseType#626

Merged
Serial-ATA merged 5 commits intoSerial-ATA:mainfrom
matteron:main
Mar 14, 2026
Merged

ItemKey: Add ItemKey::MusicBrainzReleaseType#626
Serial-ATA merged 5 commits intoSerial-ATA:mainfrom
matteron:main

Conversation

@matteron
Copy link
Contributor

@matteron matteron commented Mar 8, 2026

Hiya, needed this for reading album types (album vs ep vs single, etc).

https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html#id32

Not entirely sure if I did this correctly, I followed #573 as a template.

Copy link
Owner

@Serial-ATA Serial-ATA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one correction on the ID3v2 mapping

Co-authored-by: Alex <69764315+Serial-ATA@users.noreply.github.com>
@matteron
Copy link
Contributor Author

matteron commented Mar 9, 2026

I wasn't sure if this counted as a musicbrainz key or not. For future reference what delineates that a field is exclusively a MusicBrainz field?

@Serial-ATA
Copy link
Owner

AFAICT, there isn't really a "standard" field for release types outside of MusicBrainz. It looks like a lot of apps just make use of those MusicBrainz-specific fields (though I guess RELEASETYPE in Vorbis Comments could be generic). But now that you mention it, ItemKey::MusicBrainzReleaseType might be a better name just in case something else comes up.

@matteron matteron closed this Mar 9, 2026
@matteron matteron reopened this Mar 9, 2026
@matteron
Copy link
Contributor Author

matteron commented Mar 9, 2026

Let me know if you want the description comment changed, I wasn't sure how exactly to explain it without just saying "The release type is the album's type"

@matteron matteron requested a review from Serial-ATA March 9, 2026 12:50
Copy link
Owner

@Serial-ATA Serial-ATA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated the description a bit

@Serial-ATA Serial-ATA added this to the 0.23.3 milestone Mar 14, 2026
@Serial-ATA Serial-ATA changed the title Adding in ReleaseType ItemKey: Add ItemKey::MusicBrainzReleaseType Mar 14, 2026
@Serial-ATA Serial-ATA merged commit cb73828 into Serial-ATA:main Mar 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants