Skip to content

ItemKey: Add ItemKey::MusicBrainzReleaseType #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Serial-ATA merged 5 commits into from
Mar 14, 2026
+23 −4
Merged

ItemKey: Add ItemKey::MusicBrainzReleaseType #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf6aa13
Adding in release_type
matteron Mar 8, 2026
44b6082
Update lofty/src/tag/item.rs
matteron Mar 9, 2026
6a1d713
Renaming release type to be musicbrainz release type
matteron Mar 9, 2026
9bda9ea
Reword description
Serial-ATA Mar 14, 2026
b3296e3
Add changelog entry
Serial-ATA Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- **ItemKey**: `ItemKey::MusicBrainzReleaseType` ([PR](https://github.com/Serial-ATA/lofty-rs/pull/626))
- See <https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html#id32>

### Fixed

- **ID3v2**:
Expand Down
1 change: 1 addition & 0 deletions lofty/src/id3/v2/tag/conversion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ pub(crate) fn from_tag<'a>(
| ItemKey::MusicBrainzArtistId
| ItemKey::MusicBrainzReleaseArtistId
| ItemKey::MusicBrainzWorkId
| ItemKey::MusicBrainzReleaseType
| ItemKey::ReleaseCountry
| ItemKey::Barcode => {
let (value, _) = take_item_text_and_description(item)?;
Expand Down
21 changes: 17 additions & 4 deletions lofty/src/tag/item.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ gen_map!(
"MUSICBRAINZ_RELEASEGROUPID" => MusicBrainzReleaseGroupId,
"MUSICBRAINZ_ARTISTID" => MusicBrainzArtistId,
"MUSICBRAINZ_ALBUMARTISTID" => MusicBrainzReleaseArtistId,
"MUSICBRAINZ_WORKID" => MusicBrainzWorkId
"MUSICBRAINZ_WORKID" => MusicBrainzWorkId,
"MUSICBRAINZ_ALBUMTYPE" => MusicBrainzReleaseType,
);

gen_map!(
Expand Down Expand Up @@ -256,7 +257,8 @@ gen_map!(
"MusicBrainz Artist Id" => MusicBrainzArtistId,
"MusicBrainz Album Artist Id" => MusicBrainzReleaseArtistId,
"MusicBrainz Work Id" => MusicBrainzWorkId,
"MusicBrainz Album Release Country" => ReleaseCountry
"MusicBrainz Album Type" => MusicBrainzReleaseType,
"MusicBrainz Album Release Country" => ReleaseCountry,
);

gen_map!(
Expand Down Expand Up @@ -343,7 +345,8 @@ gen_map!(
"----:com.apple.iTunes:MusicBrainz Artist Id" => MusicBrainzArtistId,
"----:com.apple.iTunes:MusicBrainz Album Artist Id" => MusicBrainzReleaseArtistId,
"----:com.apple.iTunes:MusicBrainz Work Id" => MusicBrainzWorkId,
"----:com.apple.iTunes:MusicBrainz Album Release Country" => ReleaseCountry
"----:com.apple.iTunes:MusicBrainz Album Type" => MusicBrainzReleaseType,
"----:com.apple.iTunes:MusicBrainz Album Release Country" => ReleaseCountry,
);

gen_map!(
Expand Down Expand Up @@ -456,7 +459,8 @@ gen_map!(
"MUSICBRAINZ_RELEASEGROUPID" => MusicBrainzReleaseGroupId,
"MUSICBRAINZ_ARTISTID" => MusicBrainzArtistId,
"MUSICBRAINZ_ALBUMARTISTID" => MusicBrainzReleaseArtistId,
"MUSICBRAINZ_WORKID" => MusicBrainzWorkId
"MUSICBRAINZ_WORKID" => MusicBrainzWorkId,
"RELEASETYPE" => MusicBrainzReleaseType,
);

macro_rules! gen_item_keys {
Expand Down Expand Up @@ -738,6 +742,15 @@ gen_item_keys!(
/// Reference: <https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html#musicbrainz-work-id>
MusicBrainzWorkId,

/// MusicBrainz Release Type
///
/// A description of the MusicBrainz release group type (e.g. `album`, `single`, `ep`, etc.).
///
/// <https://musicbrainz.org/doc/Release_Group/Type>
///
/// Reference: <https://picard-docs.musicbrainz.org/en/appendices/tag_mapping.html#id32>
MusicBrainzReleaseType,

///////////////////////////////////////////////////////////////

// Flags
Expand Down