[DatePicker] Consolidate se23 logic and styles #10120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
force-pushed
the
sophie/clean-up-date-picker
branch
from
5c5cc8d
to
cd33c48
Compare
sophschneider
force-pushed
the
sophie/clean-up-date-picker
branch
from
cd33c48
to
709dd76
Compare
sophschneider
commented
Aug 21, 2023
| @@ -4,6 +4,9 @@ import {Box, Card, DatePicker, BlockStack} from '@shopify/polaris'; | |||
|
|
|||
| export default { | |||
| component: DatePicker, | |||
| parameters: { | |||
| chromatic: {delay: 300}, | |||
There was a problem hiding this comment.
added delay because I noticed some chromatic runs on unrelated PRs were taking too long to load the last date picker in the All story
sophschneider
requested review from
jesstelford,
sam-b-rose,
gwyneplaine and
laurkim
sophschneider
added a commit
that referenced
this pull request
Sep 19, 2023
### WHY are these changes introduced? Fixes #9931 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DatePicker` Component Add story delay for datepicker since the "All" test hasn't been rendering in time on some PRs ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datepicker--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-pxozkstezh.chromatic.com/?path=/story/all-components-datepicker--all)
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes Shopify#9931 ### WHAT is this pull request doing? Consolidate se23 logic and styles for `DatePicker` Component Add story delay for datepicker since the "All" test hasn't been rendering in time on some PRs ### How to 🎩 Compare production and this PR's chromatic storybook to make sure styles are the same [Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datepicker--all&globals=polarisSummerEditions2023:true) [This PR](https://5d559397bae39100201eedc1-pxozkstezh.chromatic.com/?path=/story/all-components-datepicker--all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #9931
WHAT is this pull request doing?
Consolidate se23 logic and styles for
DatePickerComponentAdd story delay for datepicker since the "All" test hasn't been rendering in time on some PRs
How to 🎩
Compare production and this PR's chromatic storybook to make sure styles are the same
Production
This PR