[Avatar] Remove se23 styles and code #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
force-pushed
the
avatar-rm-uplift
branch
from
1fcb2b4
to
1d93179
Compare
sophschneider
approved these changes
Aug 8, 2023
.changeset/tall-chicken-repeat.md
Outdated
| '@shopify/polaris': major | ||
| --- | ||
|
|
||
| Removed Summer Editions experimental styles and code from Avatar component |
There was a problem hiding this comment.
should we make changelogs for all of these that we do?
There was a problem hiding this comment.
Good point 🤔 I did this to help test the Version Packages (beta) PR which creates the prerelease of next. However, I think what we could do is just update a single changeset with a list of components included for that release.
So for the next PR removing uplift code, it would just amend and adjust this changeset 🤷 seems easier than listing out a bunch of changesets for essentially the same change but different components
sam-b-rose
force-pushed
the
avatar-rm-uplift
branch
from
1d93179
to
58d3961
Compare
laurkim
pushed a commit
that referenced
this pull request
Aug 10, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
laurkim
pushed a commit
that referenced
this pull request
Aug 10, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
5 tasks
sophschneider
pushed a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
added a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
added a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
added a commit
that referenced
this pull request
Aug 15, 2023
### WHY are these changes introduced? Related to #9899 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
added a commit
that referenced
this pull request
Aug 15, 2023
Related to #9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
added a commit
that referenced
this pull request
Aug 15, 2023
Related to #9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
kyledurand
pushed a commit
that referenced
this pull request
Aug 16, 2023
Related to #9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
kyledurand
pushed a commit
that referenced
this pull request
Aug 17, 2023
Related to #9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
sam-b-rose
changed the title
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
Related to #9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Related to Shopify#9899 <!-- Context about the problem that’s being addressed. --> Removes beta flag logic and merge override styles for Avatar component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to #9899
WHAT is this pull request doing?
Removes beta flag logic and merge override styles for Avatar component.