[ActionList] Consolidate se23 logic and styles #9911

laurkim · 2023-08-09T16:53:10Z

WHY are these changes introduced?

Resolves #9910 .

WHAT is this pull request doing?

Removes se23 beta conditional logic for ActionList.
Consolidates se23 beta styles for ActionList.

How to 🎩

Storybook

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

laurkim · 2023-08-10T12:42:21Z

polaris-react/src/components/ActionList/components/Section/Section.tsx

        {...(hasMultipleSections && {paddingBlockStart: '0'})}
-        {...(sectionRole && !polarisSummerEditions2023 && {role: sectionRole})}


Had to remove this line due to failing accessibility checks

Its good to remove! I added the one below on VerticalStack to work for se23 so the one above can be safely deleted now :D

laurkim · 2023-08-10T12:47:08Z

fyi, 4 of the 5 storybook changes look like them stem from the popover issue discussed in the project channel in slack. I verified on the Chromatic Storybook for this PR that the 5 stories still look as expected and have no diff when compared to prod storybook with beta flag on so I've gone ahead and accepted them.

sophschneider · 2023-08-10T14:30:40Z

polaris-react/src/components/ActionList/components/Section/Section.tsx

        {...(hasMultipleSections && {paddingBlockStart: '0'})}
-        {...(sectionRole && !polarisSummerEditions2023 && {role: sectionRole})}


Its good to remove! I added the one below on VerticalStack to work for se23 so the one above can be safely deleted now :D

### WHY are these changes introduced? Resolves #9910 . ### WHAT is this pull request doing? Removes se23 beta conditional logic for `ActionList`. Consolidates se23 beta styles for `ActionList`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-xfazrnicvb.chromatic.com/?path=/story/all-components-actionlist--all) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

### WHY are these changes introduced? Resolves Shopify#9910 . ### WHAT is this pull request doing? Removes se23 beta conditional logic for `ActionList`. Consolidates se23 beta styles for `ActionList`. ### How to 🎩 [Storybook](https://5d559397bae39100201eedc1-xfazrnicvb.chromatic.com/?path=/story/all-components-actionlist--all) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide

laurkim added the v12 label Aug 9, 2023

laurkim self-assigned this Aug 9, 2023

laurkim changed the title ~~[AccountConnection] Consolidate se23 logic and styles~~ [ActionList] Consolidate se23 logic and styles Aug 9, 2023

laurkim force-pushed the lo/rm-uplift-action-list branch 3 times, most recently from 54045fb to f811e19 Compare August 10, 2023 12:14

laurkim added 2 commits August 10, 2023 08:17

[ActionList] Consolidate se23 logic and styles

16aff11

Update changeset

6a62866

laurkim force-pushed the lo/rm-uplift-action-list branch from f811e19 to 6a62866 Compare August 10, 2023 12:17

laurkim commented Aug 10, 2023

View reviewed changes

laurkim marked this pull request as ready for review August 10, 2023 12:47

laurkim requested review from jesstelford, sam-b-rose, gwyneplaine and sophschneider August 10, 2023 12:48

sophschneider approved these changes Aug 10, 2023

View reviewed changes

laurkim merged commit 053dba2 into next Aug 10, 2023
11 checks passed

laurkim deleted the lo/rm-uplift-action-list branch August 10, 2023 15:18

laurkim linked an issue Aug 10, 2023 that may be closed by this pull request

[ActionList] Consolidate se23 logic and styles #9910

Closed

gwyneplaine mentioned this pull request Aug 11, 2023

[Checkbox] consolidate se23 styles and logic #10014

Closed

5 tasks

sam-b-rose mentioned this pull request Sep 19, 2023

Remove nav level rule #10568

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ActionList] Consolidate se23 logic and styles #9911

[ActionList] Consolidate se23 logic and styles #9911

laurkim commented Aug 9, 2023 •

edited

Loading

laurkim Aug 10, 2023

sophschneider Aug 10, 2023

laurkim commented Aug 10, 2023

sophschneider Aug 10, 2023

		{...(hasMultipleSections && {paddingBlockStart: '0'})}
		{...(sectionRole && !polarisSummerEditions2023 && {role: sectionRole})}

[ActionList] Consolidate se23 logic and styles #9911

[ActionList] Consolidate se23 logic and styles #9911

Conversation

laurkim commented Aug 9, 2023 • edited Loading

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

laurkim Aug 10, 2023

Choose a reason for hiding this comment

sophschneider Aug 10, 2023

Choose a reason for hiding this comment

laurkim commented Aug 10, 2023

sophschneider Aug 10, 2023

Choose a reason for hiding this comment

laurkim commented Aug 9, 2023 •

edited

Loading