Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dx): add a code-workspace for vscode #7285

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Jun 27, 2024

User description

Background

Developing autogpt is kinda a pain rn across all the different services. This allows you to have segmented terminals for each that don't try and activate weird poetry envs automatically

Changes 🏗️

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

PR Type

Enhancement, Configuration changes


Description

  • Added a new VSCode workspace configuration file to streamline development.
  • Defined folder paths for various project directories to organize the workspace.
  • Configured Python analysis settings to enhance code intelligence and auto-completion.
  • Recommended useful extensions for Python development, Flutter, Prisma, SQLite, and workspace terminals.

Changes walkthrough 📝

Relevant files
Configuration changes
autogpt-workspace.code-workspace
Add VSCode workspace configuration for AutoGPT project     

.vscode/autogpt-workspace.code-workspace

  • Added a new VSCode workspace configuration file.
  • Defined folder paths for various project directories.
  • Set Python analysis settings for better code intelligence.
  • Recommended extensions for Python, Flutter, Prisma, SQLite, and
    workspace terminals.
  • +69/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Description updated to latest commit (8120b4e)

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    Copy link

    netlify bot commented Jun 27, 2024

    Deploy Preview for auto-gpt-docs canceled.

    Name Link
    🔨 Latest commit 2e4276d
    🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6690148375f4b20007b72b0a

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Enhance type checking by setting it to strict mode

    To ensure better compatibility and performance, consider setting the
    python.analysis.typeCheckingMode to strict instead of basic.

    .vscode/autogpt-workspace.code-workspace [47]

    -"python.analysis.typeCheckingMode": "basic"
    +"python.analysis.typeCheckingMode": "strict"
     
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Setting the type checking mode to strict can catch more potential issues during development, improving code quality and reducing bugs.

    8

    @ntindle ntindle requested a review from Pwuts July 10, 2024 11:47
    Pwuts
    Pwuts previously approved these changes Jul 11, 2024
    .vscode/autogpt-workspace.code-workspace Outdated Show resolved Hide resolved
    Torantulino
    Torantulino previously approved these changes Jul 11, 2024
    @ntindle ntindle dismissed stale reviews from Torantulino and Pwuts via 2e4276d July 11, 2024 17:21
    @ntindle ntindle enabled auto-merge (squash) July 11, 2024 17:22
    @ntindle ntindle merged commit 7cf6d3f into master Jul 11, 2024
    10 checks passed
    @ntindle ntindle deleted the ntindle/workspace-settings branch July 11, 2024 17:24
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Status: Done
    Development

    Successfully merging this pull request may close these issues.

    3 participants