Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dx): add a code-workspace for vscode #7285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions .vscode/autogpt-workspace.code-workspace
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
{
"folders": [
{
"name": ".github",
"path": "../.github"
},
{
"name": ".vscode",
"path": "../.vscode"
},
{
"name": "assets",
"path": "../assets"
},
Comment on lines +3 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't need separate interpreters or environments so can be covered by the root folder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair drop them

{
"name": "autogpt",
"path": "../autogpt"
},
{
"name": "benchmark",
"path": "../benchmark"
},
{
"name": "docs",
"path": "../docs"
},
{
"name": "forge",
"path": "../forge"
},
{
"name": "frontend",
"path": "../frontend"
},
{
"name": "autogpt_server",
"path": "../rnd/autogpt_server"
},
{
"name": "[root]",
"path": ".."
}
],
"settings": {
"python.analysis.useLibraryCodeForTypes": true,
"python.analysis.autoImportCompletions": true,
"python.analysis.typeCheckingMode": "basic",
"python.analysis.inlayHints.functionReturnTypes": true,
"python.analysis.autoFormatStrings": true,
"python.analysis.fixAll": [
"source.convertImportFormat",
"source.unusedImports"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually quite annoying imo, because if you add an import with the intention of using it later and you hit save, the import disappears.

Copy link
Member Author

@ntindle ntindle Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it is fine with me, just make the commits as I’m OOO for the next week or so. The workspace splitting and extension recommendations matter here more imo. Each project will probably have its own settings

]
},
"extensions": {
"recommendations": [
"charliermarsh.ruff",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one of the 5 projects in the repo currently uses Ruff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each project uses diff things. Might as well suggest what we have

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this file cause Ruff to make all kinds of automatic changes, even in projects that don't use Ruff?

"dart-code.flutter",
"ms-python.black-formatter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff + Black?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some use ruff some use black

"ms-python.vscode-pylance",
"prisma.prisma",
"qwtel.sqlite-viewer",
"joshx.workspace-terminals"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode already lets you choose when opening a terminal. If we have 10 folders by default I don't want it to open up 10 terminals on start-up, because there is no way I'll actually be working on all 10 folders at the same time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh lol there’s a setting to disable that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what's the point of the extension? Afaics that's the only thing it does.

]
}
}
Loading