Shadowkin Rework #1200
Open
Shadowkin Rework #1200
+241
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxxoTrystan
added
the
Type: Rework
github-actions
bot
added
Changes: C#
github-actions
bot
added
Changes: Localization
FoxxoTrystan
requested review from
a team,
VMSolidus,
Aidenkrz,
Remuchi,
DEATHB4DEFEAT,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
FoxxoTrystan
added
Priority: 2-High
|
PR Ready for review. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: FoxxoTrystan <[email protected]>
DEATHB4DEFEAT
approved these changes
Dec 7, 2024
Comment on lines
120
to
+125
| EnsureComp<PsionicComponent>(uid, out var magic); | ||
| magic.Mana = 250; | ||
| magic.MaxMana = 250; | ||
| magic.Mana = 200; | ||
| magic.MaxMana = 200; | ||
| magic.ManaGain = 0.25f; | ||
| magic.BypassManaCheck = true; | ||
| magic.Removable = false; | ||
| magic.MindbreakingFeedback = "shadowkin-blackeye"; | ||
| magic.NoMana = "shadowkin-tired"; |
There was a problem hiding this comment.
I think you can do this with something like this
if (!HasComp<PsionicComponent>(uid))
AddComp(uid, new PsionicComponent
{
Mana = 200;
MaxMana = 200;
// etc...
});
Co-authored-by: DEATHB4DEFEAT <[email protected]> Signed-off-by: FoxxoTrystan <[email protected]>
sleepyyapril
approved these changes
Dec 7, 2024
75 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR compleatly rework shadowkins, slightly been forced this makes shadowkins more "psionic creature" then anything else.
This is a WIP, but in general this PR make Shadowkin "Psionic" and fall under the same rule.
RIP Shadowkin for me but ye.
CHANGES TO SHADOWKINS:
Shadowkins now follow the laws of psionic, they will always spawn with DarkSwapPower but can generate others power, they do not spawn with Shadeskip by default anymore, Mana has been lower from 250 to 200; they can now pick normal psionic jobs.
Changes to DarkSwap:
DarkSwap cost 30 Mana and will raise glimmer on use, its will drain 1 Mana/Sec, will eject the user when mana is fully drained.
DarkSwap is now a random roll.
Changes to Psionics:
Added the Mana Alert for all psionics
TODO
Media
N/A
Changelog
🆑