Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] Port Guidebook Tables From Wizden PR #28484 #1427

Merged

Conversation

CerberusWolfie
Copy link
Contributor

@CerberusWolfie CerberusWolfie commented Jan 5, 2025

Description

This ports the Guidebook Tables to allow <Table> and <ColorBox> embeds in the Guidebook.
This just adds extra XML tags to use in rich-text.


TODO

  • Cherry-Pick the PR.
  • Tested to make sure it works. It does actively work.

Media

Guidebook Screenshot

![image](https://github.com/user-attachments/assets/289e4c72-dcef-4489-b89e-5a2d6367124f)

NOTE: This screenshot was taken in the dev-environment. I just copy-pasted my SOP for Alert Levels to check it, since it uses both the <Table> and <ColorBox> identifiers.


Changelog

🆑

  • add: Added and identifiers. Go wild in SOP!

* PJB's cool table control (it probably doesn't work)

* ok wait wrong file

* Guidebook Tables
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: YML Changes any yml files labels Jan 5, 2025
@SimpleStation14 SimpleStation14 changed the title [Port] Port Guidebook Tables from Wizden PR #28484 [Port] Port Guidebook Tables From Wizden PR #28484 Jan 5, 2025
@CerberusWolfie
Copy link
Contributor Author

Forgot to mention. It's this PR specifically: PR #28484

@VMSolidus VMSolidus merged commit 75bb8d3 into Simple-Station:master Jan 5, 2025
13 of 14 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 5, 2025
@CerberusWolfie CerberusWolfie deleted the MergeTablesUpstream branch January 5, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants