Better runtime error filtering #8195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
sovdeeth
added
the
enhancement
skriptlang-automation
bot
added
the
needs reviews
Absolutionism
approved these changes
Sep 18, 2025
1 task
APickledWalrus
approved these changes
Sep 30, 2025
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/log/runtime/RuntimeErrorManager.java
Show resolved
Hide resolved
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.13 Releases
skriptlang-automation
bot
added
feature-ready
github-project-automation
bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.13 Releases
skriptlang-automation
bot
added
completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
RuntimeErrorManager enforced a standard filtering system for all consumers based on the values in config.sk. This meant that the runtime error catcher could not adequately catch errors, since they would be suppressed after reaching the limits. A per-consumer filtering system was needed.
Solution
Allows each consumer to provide its own filter, or null for no filter. Defaults to the standard config-driven filter.
REManager internally uses a filter->set map to avoid giving a filter the same error twice.
Testing Completed
Manual testing and edits to existing tests to ensure functionality.
Supporting Information
Completes: #7921
Related: none