Replace thiserror with manual impls #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the heavy thiserror dependency by replacing its automatically generated implementations with manually written ones. Hopefully the newly written implementations are identical to the previous ones, but just in case I've marked this as a breaking change. Since there is already a breaking change on master this shouldn't be a big deal. Closes #126 Signed-off-by: John Nunley <[email protected]>
notgull
changed the title
Signed-off-by: John Nunley <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 85.36% 85.63% +0.27%
==========================================
Files 14 13 -1
Lines 1858 1852 -6
==========================================
Hits 1586 1586
+ Misses 272 266 -6 ☔ View full report in Codecov by Sentry. |
Signed-off-by: John Nunley <[email protected]>
elinorbgr
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the heavy thiserror dependency by replacing its
automatically generated implementations with manually written ones. Hopefully
the newly written implementations are identical to the previous ones, but just
in case I've marked this as a breaking change. Since there is already a breaking change on master this shouldn't be a big deal.
Closes #126