Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thiserror with manual impls #186

Merged
merged 3 commits into from
May 30, 2024
Merged

Replace thiserror with manual impls #186

merged 3 commits into from
May 30, 2024

Commits on May 19, 2024

  1. break: Use manual impls instead of thiserror 

    This commit removes the heavy thiserror dependency by replacing its
automatically generated implementations with manually written ones. Hopefully
the newly written implementations are identical to the previous ones, but just
in case I've marked this as a breaking change. Since there is already a breaking
change on master this shouldn't be a big deal.

Closes #126

Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed May 19, 2024
    Configuration menu
    Copy the full SHA
    87adfd3 View commit details
    Browse the repository at this point in the history

  2. m: Fix thiserror for non-optional features 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a239fb6 View commit details
    Browse the repository at this point in the history

  3. fix: Add coverage(off) to new error methods 

    Signed-off-by: John Nunley <[email protected]>
    @notgull
    notgull committed May 19, 2024
    Configuration menu
    Copy the full SHA
    73a7564 View commit details
    Browse the repository at this point in the history