fix filename encode issue when download chinese filename #7542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrcaSlicer: 2.2.0
Operator: Win10/11 Simplified Chinese
when download from makerworld.com.cn, if filename contain chinese, the downloaded filename is in wrong encode. if the invalid encode contain character not allowed in windows path, the download will failed.
check the wxwidget docs: https://docs.wxwidgets.org/3.2.6/overview_unicode.html
So, this code
wxString(escaped_url)
, wxWidgets will think the string is in current locale(gbk in chinese windows).test file: https://makerworld.com.cn/zh/models/648200?designId=648200#profileId-589194
Screenshots/Recordings/Graphs
before:
after:
this is also can use python to check:
Tests