Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix filename encode issue when download chinese filename #7542

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix filename encode issue when download chinese filename #7542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b360c33
fix filename encode issue when download chinese filename
zlbruce Nov 21, 2024
fa45cc1
Merge branch 'main' into patch-1
zlbruce Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/slic3r/GUI/Downloader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ void Downloader::start_download(const std::string& full_url)
size_t id = get_next_id();
std::string escaped_url = FileGet::escape_url(full_url.substr(results.length()));
if (is_bambustudio_open(full_url) || (is_orca_open(full_url) && is_makerworld_link(full_url)))
plater->request_model_download(escaped_url);
plater->request_model_download(wxString::FromUTF8(escaped_url));
else {
std::string text(escaped_url);
m_downloads.emplace_back(std::make_unique<Download>(id, std::move(escaped_url), this, m_dest_folder));
Expand Down Expand Up @@ -254,4 +254,4 @@ void Downloader::set_download_state(int id, DownloadState state)
}

}
}
}