Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates pykilosort to 1.4.7 #68

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vncntprvst
Copy link
Contributor

Question / suggestion: the image's tag could indicate which CUDA version was used to build the container, in addition to the pykilosort version number. See build.sh. Just a thought.

@alejoe91
Copy link
Member

alejoe91 commented Mar 4, 2024

HI @vncntprvst

Thank you so much for this and sorry for our delay in reviewing. Will get nack into this by the end of the week :)

I think that adding CUDA versions to the tag is a good idea. I'll do it for Kilosort4 too!

docker build -t spikeinterface/pykilosort-base:latest -t spikeinterface/pykilosort-base:ibl-1.4.7_cuda-11.5.2 .

# version info
# 01/21/2024 - IBL 1.4.7 CUDA 11.3.1 Ubuntu 20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this internal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants