-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates pykilosort to 1.4.7 #68
Open
vncntprvst
wants to merge
6
commits into
SpikeInterface:main
Choose a base branch
from
vncntprvst:pykilosort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b1bb68b
updates pykilosort
vncntprvst 3f5450e
updates pykilosort
vncntprvst d002e22
Merge remote-tracking branch 'upstream/main' into pykilosort
vncntprvst 6a62434
for PR
vncntprvst 976c62b
updates rm for PR
vncntprvst bf200dc
updates push.sh for PR
vncntprvst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM nvidia/cuda:10.0-base-ubuntu18.04 | ||
FROM nvidia/cuda:11.5.2-base-ubuntu20.04 | ||
|
||
LABEL maintainer="Alessio Buccino <[email protected]>" | ||
|
||
|
@@ -7,6 +7,7 @@ LABEL maintainer="Alessio Buccino <[email protected]>" | |
RUN apt update && \ | ||
apt install -y --no-install-recommends \ | ||
libfftw3-dev \ | ||
nano \ | ||
git \ | ||
wget && \ | ||
apt clean && \ | ||
|
@@ -31,11 +32,15 @@ RUN echo ". $CONDA_DIR/etc/profile.d/conda.sh" >> /root/.profile | |
RUN conda init bash | ||
|
||
# Install IBL python port of pykilosort | ||
RUN git clone -b 1.4.3 https://github.com/int-brain-lab/pykilosort.git /src/pykilosort | ||
RUN git clone -b 1.4.7 https://github.com/int-brain-lab/pykilosort.git /src/pykilosort | ||
WORKDIR /src/pykilosort | ||
|
||
# modify env file so that env extends on base | ||
RUN sed -i "s/pyks2/base/" pyks2.yml | ||
# edit the python line to keep the current python version (e.g., 3.9), otherwise it may upgrade (e.g., to 3.10.x), conflict with numba and break the installation. | ||
RUN PYTHON_VERSION=$(python --version | cut -d ' ' -f 2) && \ | ||
sed -i "s/- python.*/- python=$PYTHON_VERSION/" pyks2.yml | ||
# remove the spikeinterface dependency | ||
RUN sed -i "s/- spikeinterface//" pyks2.yml | ||
|
||
# Create environment | ||
|
@@ -44,7 +49,7 @@ RUN conda env update --name base --file pyks2.yml --prune | |
# Install pykilosort | ||
RUN conda install --quiet --yes ipykernel && \ | ||
python -m ipykernel install --user --display-name "pyKilosort" && \ | ||
conda develop . | ||
pip install -e . | ||
RUN conda clean --all --yes | ||
|
||
#--name pyks2 | ||
WORKDIR / |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
#!/bin/bash | ||
|
||
docker build -t spikeinterface/pykilosort-base:latest -t spikeinterface/pykilosort-base:1.4.3 . | ||
docker build -t spikeinterface/pykilosort-base:latest -t spikeinterface/pykilosort-base:ibl-1.4.7_cuda-11.5.2 . | ||
|
||
# version info | ||
# 01/21/2024 - IBL 1.4.7 CUDA 11.3.1 Ubuntu 20.04 | ||
# 02/01/2024 - IBL 1.4.7 CUDA 11.5.2 Ubuntu 20.04 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#!/bin/bash | ||
|
||
docker push --all-tags spikeinterface/pykilosort-base | ||
docker push --all-tags spikeinterface/pykilosort-base |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this internal?