fix: accept base58-encoded transaction_message in vault_transaction_create CLI#176
Open
kukaklaudio wants to merge 1 commit intoSquads-Protocol:mainfrom
Open
Conversation
The vault_transaction_create CLI command declared transaction_message as Vec<u8>, which clap cannot properly parse from command-line arguments (it expects space-separated individual byte values, which is impractical for transaction messages). Changed the argument to accept a base58-encoded string, which is decoded to Vec<u8> at runtime. This is consistent with how Solana CLI tools typically handle binary data. Fixes Squads-Protocol#159
|
Someone is attempting to deploy a commit to the squads Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
vault_transaction_createCLI command declarestransaction_messageasVec<u8>:Clap parses
Vec<u8>by expecting space-separated individual byte values on the command line (e.g.,--transaction_message 1 2 3 4), which is completely impractical for transaction messages that are hundreds of bytes long.Fix
Changed the argument type to
Stringand decode from base58 at runtime:This is consistent with how Solana CLI tools handle binary data and allows users to pass transaction messages as a single base58 string.
Fixes #159