Skip to content

fix: accept base58-encoded transaction_message in vault_transaction_create CLI #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kukaklaudio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accept base58-encoded transaction_message in vault_transaction_create CLI #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ dialoguer = "0.11.0"
indicatif = "0.17.7"
colored = "2.1.0"
bincode = "1.3"
bs58 = "0.5"
# Solana deps
solana-sdk = "2.2.20"
# local deps
Expand Down
7 changes: 6 additions & 1 deletion cli/src/command/vault_transaction_create.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ pub struct VaultTransactionCreate {
#[arg(long)]
vault_index: u8,

/// Base58-encoded transaction message bytes
#[arg(long)]
transaction_message: Vec<u8>,
transaction_message: String,

/// Memo to be included in the transaction
#[arg(long)]
Expand Down Expand Up @@ -87,6 +88,10 @@ impl VaultTransactionCreate {
approve,
} = self;

let transaction_message = bs58::decode(&transaction_message)
.into_vec()
.map_err(|e| eyre::eyre!("Invalid base58 transaction_message: {}", e))?;

let program_id =
program_id.unwrap_or_else(|| "SQDS4ep65T869zMMBKyuUq6aD6EgTu8psMjkvj52pCf".to_string());

Expand Down