Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sumologic.logs.kubelet.enabled key #3168

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tangyfruits
Copy link

@tangyfruits tangyfruits commented Jul 26, 2023

Checklist

This addresses issue #3167
Changelog + tests to come

  • Changelog updated or skip changelog label added
  • Documentation updated
  • Template tests added for new features
  • Integration tests added or modified for major features

@sumo-drosiek
Copy link
Contributor

Kubelet logs are systemd logs as well.

Please see the following code:

This should be handled properly, otherwise kubelet logs won't work anyway

@tangyfruits
Copy link
Author

Kubelet logs are systemd logs as well.

Please see the following code:

This should be handled properly, otherwise kubelet logs won't work anyway

Hmm fair call. I did find it quite confusing that the kubelet config was a sibling of systemd. I had to dig into the helmchart to work out that I had to enable systemd. Maybe there is consideration make kubelet log config a child of systemd instead? It was unintuitive to me using the chart to have to enable systemd - not sure if anyone else agrees

@sumo-drosiek
Copy link
Contributor

Hmm fair call. I did find it quite confusing that the kubelet config was a sibling of systemd. I had to dig into the helmchart to work out that I had to enable systemd. Maybe there is consideration make kubelet log config a child of systemd instead? It was unintuitive to me using the chart to have to enable systemd - not sure if anyone else agrees

This is fair ask. I think it should be separated to avoid confusion, but this is not our priority right now.

As a workaround, you may override sumologic.logs.systemd.units to use only kubelet related, then even if systemd (not kubeelt) pipeline will be enabled it won't get any data to process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants