-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sumologic.logs.kubelet.enabled key #3168
base: main
Are you sure you want to change the base?
Conversation
Kubelet logs are systemd logs as well. Please see the following code: sumologic-kubernetes-collection/deploy/helm/sumologic/conf/logs/collector/otelcol/config.yaml Line 265 in 7c1008b
This should be handled properly, otherwise kubelet logs won't work anyway |
Hmm fair call. I did find it quite confusing that the kubelet config was a sibling of systemd. I had to dig into the helmchart to work out that I had to enable systemd. Maybe there is consideration make kubelet log config a child of systemd instead? It was unintuitive to me using the chart to have to enable systemd - not sure if anyone else agrees |
This is fair ask. I think it should be separated to avoid confusion, but this is not our priority right now. As a workaround, you may override |
Checklist
This addresses issue #3167
Changelog + tests to come