Skip to content

Conversation

@eikek
Copy link
Member

@eikek eikek commented Oct 24, 2025

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1077.dev.renku.ch

@coveralls
Copy link

coveralls commented Oct 24, 2025

Pull Request Test Coverage Report for Build 18901460589

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 86.818%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/storage/rclone.py 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/notebooks/util/retries.py 1 59.38%
components/renku_data_services/session/models.py 1 95.33%
components/renku_data_services/crc/core.py 2 77.96%
Totals Coverage Status
Change from base Build 18900465468: 0.01%
Covered Lines: 22722
Relevant Lines: 26172

💛 - Coveralls

@eikek eikek marked this pull request as ready for review October 29, 2025 06:46
@eikek eikek requested review from a team, SalimKayal and sgaist as code owners October 29, 2025 06:46
@eikek eikek force-pushed the eikek/s3-endpoint-fix branch from 8f77410 to 2bf862c Compare October 29, 2025 06:46
@leafty leafty self-requested a review October 29, 2025 07:42
@eikek eikek force-pushed the eikek/s3-endpoint-fix branch from 2bf862c to 6f48d73 Compare October 29, 2025 08:20
sgaist
sgaist previously approved these changes Oct 29, 2025
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks OK, it would be nice if we could test actually mounting 😅 .

@eikek
Copy link
Member Author

eikek commented Oct 29, 2025

Fyi, I have credentials to test and it turned out that these default values have to be injected at the correct places.

@eikek eikek marked this pull request as draft October 29, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants