feat(zksdk): improve type safety for fiat-shamir transformations

[Rexicon226]

No description provided.

[Rexicon226]

• feature(txn): speedup transaction verification #950
• feat(zksdk): improve type safety for fiat-shamir transformations #942 👈 (View in Graphite)
• feature(conformance): fuzzcorp integration #949
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[yewman]

Looks good, do you know what is causing the conformance issues?

[Rexicon226]

Yes, it has to do with core-bpf being enabled for the stake program in the test-vectors, seems we aren't correctly doing something in that area. Haven't looked into it further yet, think @kprotty was going to?

[codecov]

Codecov Report

❌ Patch coverage is 99.75550% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/runtime/program_loader.zig	83.33%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/crypto/bn254/lib.zig	97.59% <100.00%> (+<0.01%)	⬆️
src/replay/preprocess_transaction.zig	97.29% <100.00%> (+0.07%)	⬆️
src/zksdk/merlin.zig	98.60% <100.00%> (+0.13%)	⬆️
src/zksdk/range_proof/bulletproofs.zig	99.78% <100.00%> (-0.01%)	⬇️
src/zksdk/range_proof/ipp.zig	100.00% <100.00%> (ø)
src/zksdk/sigma_proofs/ciphertext_ciphertext.zig	100.00% <100.00%> (ø)
src/zksdk/sigma_proofs/ciphertext_commitment.zig	100.00% <100.00%> (ø)
...ksdk/sigma_proofs/grouped_ciphertext/handles_2.zig	98.74% <100.00%> (-0.01%)	⬇️
...ksdk/sigma_proofs/grouped_ciphertext/handles_3.zig	99.72% <100.00%> (-0.01%)	⬇️
src/zksdk/sigma_proofs/percentage_with_cap.zig	93.51% <100.00%> (+0.33%)	⬆️
... and 3 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.