refactor(vm): don't allocate for syscall registry #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
Rexicon226/no-allocating-in-syscall-map
branch
from
bbbdb05 to
02b6024
Compare
Rexicon226
force-pushed
the
Rexicon226/no-allocating-in-syscall-map
branch
5 times, most recently
from
de21bd2 to
c913623
Compare
Rexicon226
force-pushed
the
Rexicon226/no-allocating-in-syscall-map
branch
from
c913623 to
2534794
Compare
InKryption
reviewed
Nov 5, 2025
Comment on lines
744
to
+745
| test "WriteBatch.deleteRange" { | ||
| if (true) return error.SkipZigTest; |
There was a problem hiding this comment.
What's up with this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.