refactor(vm): don't allocate for syscall registry

conformance/src/elf.zig

@@ -7,7 +7,6 @@ const ELFLoaderCtx = pb.ELFLoaderCtx;
 const ElfLoaderEffects = pb.ELFLoaderEffects;
 
 const svm = sig.vm;
-const syscalls = svm.syscalls;
 const Elf = svm.Elf;
 const Executable = svm.Executable;
 const Config = svm.Config;
@@ -49,26 +48,21 @@ fn executeElfTest(ctx: ELFLoaderCtx, allocator: std.mem.Allocator) !ElfLoaderEff
         .calldests = std.ArrayList(u64).init(allocator),
     };
 
-    const env = svm.Environment{ .config = .{}, .loader = .{} };
+    const env: svm.Environment = .{
+        .config = .{},
+        .loader = .ALL_DISABLED,
+    };
     var loader = env.loader;
-    defer loader.deinit(allocator);
 
     inline for (.{
-        .{ "sol_log_", syscalls.log },
-        .{ "sol_log_64_", syscalls.log64 },
-        .{ "sol_log_pubkey", syscalls.logPubkey },
-        .{ "sol_log_compute_units_", syscalls.logComputeUnits },
-        .{ "sol_memset_", syscalls.memops.memset },
-        .{ "sol_memcpy_", syscalls.memops.memcpy },
-        .{ "abort", syscalls.abort },
-    }) |entry| {
-        const name, const function = entry;
-        _ = try loader.registerHashed(
-            allocator,
-            name,
-            function,
-        );
-    }
+        .sol_log_,
+        .sol_log_64_,
+        .sol_log_pubkey,
+        .sol_log_compute_units_,
+        .sol_memset_,
+        .sol_memcpy_,
+        .abort,
+    }) |syscall| loader.enable(syscall);
 
     const config: Config = .{
         .maximum_version = .v0,

conformance/src/instruction_execute.zig

@@ -100,8 +100,7 @@ fn executeInstruction(
     }
 
     // Override vm environment in the tc context
-    vm_environment.* = try sig.vm.Environment.initV1(
-        allocator,
+    vm_environment.* = sig.vm.Environment.initV1(
         tc.feature_set,
         &tc.compute_budget,
         tc.slot,

conformance/src/txn_execute.zig

@@ -206,8 +206,10 @@ fn executeTxnContext(
     var stakes_cache = try StakesCache.init(allocator);
     defer stakes_cache.deinit(allocator);
 
-    var vm_environment: vm.Environment = .{};
-    defer vm_environment.deinit(allocator);
+    var vm_environment: vm.Environment = .{
+        .loader = .ALL_DISABLED,
+        .config = .{},
+    };
 
     var capitalization: Atomic(u64) = .init(0);
 
@@ -353,8 +355,7 @@ fn executeTxnContext(
                 });
             }
 
-            vm_environment = try vm.Environment.initV1(
-                allocator,
+            vm_environment = vm.Environment.initV1(
                 &feature_set,
                 &compute_budget,
                 slot,

conformance/src/utils.zig

@@ -95,7 +95,7 @@ pub fn createTransactionContext(
         try allocator.create(sig.vm.Environment);
     vm_environment.* = sig.vm.Environment{
         .config = .{},
-        .loader = .{},
+        .loader = .ALL_DISABLED,
     };
 
     const program_map = if (environment.program_map) |ptr|
@@ -146,16 +146,14 @@ pub fn deinitTransactionContext(
     tc: TransactionContext,
 ) void {
     allocator.destroy(tc.feature_set);
+    allocator.destroy(tc.vm_environment);
 
     tc.epoch_stakes.deinit(allocator);
     allocator.destroy(tc.epoch_stakes);
 
     tc.sysvar_cache.deinit(allocator);
     allocator.destroy(tc.sysvar_cache);
 
-    tc.vm_environment.deinit(allocator);
-    allocator.destroy(tc.vm_environment);
-
     for (tc.program_map.values()) |*v| v.deinit(allocator);
     var program_map = tc.program_map.*;
     program_map.deinit(allocator);