Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tapisproject_cms #176

Merged
merged 5 commits into from
Jun 27, 2023
Merged

feat: tapisproject_cms #176

merged 5 commits into from
Jun 27, 2023

Conversation

taoteg
Copy link
Collaborator

@taoteg taoteg commented Jun 27, 2023 •
edited by wesleyboar
Loading

Overview

Migrate project from Core-CMS-Resources.

@taoteg taoteg requested a review from wesleyboar June 27, 2023 20:58
taoteg
taoteg commented Jun 27, 2023
View reviewed changes
matcssi_cms/src/taccsite_cms/settings_custom.py
@@ -7,7 +7,7 @@
# TACC: LOGOS
########################

LOGO = [
LOGO = [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a random OCD edit I made.

wesleyboar
wesleyboar reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. Looks good. I do wanna test before approval and merge. We can sync and remember together how to do that.

wesleyboar
wesleyboar approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed. Success.

@taoteg taoteg merged commit 26ba81f into main Jun 27, 2023
1 check passed
@taoteg taoteg deleted the task/migrate-tapisproject branch June 27, 2023 21:47
@wesleyboar wesleyboar changed the title tapis-project conversion from resources into custom. feat: tapisproject Jun 27, 2023
@wesleyboar wesleyboar changed the title feat: tapisproject feat: tapisproject_cms Jun 27, 2023
This was referenced Jun 27, 2023
Merged
Merged
@wesleyboar wesleyboar mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taoteg @wesleyboar