Fix/did web create key #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranCohen
requested review from
decentralgabe,
nitro-neal and
andresuribe87
as code owners
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 67 67
Lines 7334 7334
=======================================
Hits 4177 4177
Misses 2419 2419
Partials 738 738
|
andresuribe87
approved these changes
Jul 14, 2023
Yup I could do that. |
|
Added tests, let me know if you'd like me to modify it or add to it in any way to enhance overall testing.
This is what it looked like failing on main. |
LiranCohen
force-pushed
the
fix/did-web-create-key-id
branch
from
74d7d03
to
b80a228
Compare
|
Rebased main and pushed. |
* Did Web Validation * lint and test fix * content type const --------- Co-authored-by: Gabe <[email protected]>
* Fixed resolution problems. * Add canonical ID when applying patch changes to a did doc * ptr
* Added docs and fixed required fields for resolution * Nicer lines
* update vcs * fix lint * update go version * pr comments * pr comments
|
sorry @LiranCohen can you rebase once more and I'll merge? |
|
merging in #430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was fiddling with did:web and noticed that the owner key ID and Controller were mismatched within the CreateDoc function.
Searched around and saw that it was also mismatched on the did:peer resolve method.