-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumping web5 versions #149
Conversation
…hods in dev-tools
🦋 Changeset detectedLatest commit: 025b95d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"ms": "2.1.3", | ||
"query-string": "8.1.0", | ||
"typeid-js": "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding ms
and typeid-js
to http-client
in this PR? If ms
is necessary in dependencies
, why is @types/ms
in devDepencencies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding ms and typeid-js to http-client in this PR?
so this PR is part of a 4 PR series in an effort to break down moe's 122-request-token PR which is a chonky boi.
i just ported over the client/package.json changes from the original PR, which includes ms and typeid-js since they're being used by the client during request token generation.
the PR that will use the ms and typeid-js is here
If ms is necessary in dependencies, why is @types/ms in devDepencencies?
i thought we needed to include @types/xyz in devDependencies that correspond to package xyz in dependencies in order to write with type checking during development. is that incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought we needed to include @types/xyz in devDependencies that correspond to package xyz in dependencies in order to write with type checking during development. is that incorrect?
ah, u right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yee that's correct @jiyoontbd
@@ -78,7 +82,7 @@ | |||
"mkdirp": "3.0.1", | |||
"mocha": "10.2.0", | |||
"rimraf": "4.4.0", | |||
"sinon": "15.0.2", | |||
"sinon": "17.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should sinon
and @types/sinon
have matching versions? Only different by patch version so probably not a big deal regardless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, ty!
packages/protocol/src/crypto.ts
Outdated
const algorithmName = privateKeyJwk?.['alg'] || '' | ||
let namedCurve = Crypto.extractNamedCurve(privateKeyJwk) | ||
const algorithmName = privateKeyJwk['alg'] || '' | ||
const namedCurve = privateKeyJwk['crv'] || '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing because you're reverting some of the changes from #141. Might need to rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating web5 deps unblocks #147, which has a TODO in protocol/src/did-resolver.ts
. We can tackle that in this PR or a follow up, up to you @jiyoontbd.
c1730b9
to
c14d142
Compare
TBDocs Report 🛑 Errors: 0 @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-01-23T22:33:33Z |
ci is still failing because of test vector tests in packages/protocol, but that will be addressed in this test vector specific PR |
🎉 nice! Can we also clean up this TODO in
I can push a quick commit for that if you prefer - lmk! |
@kirahsapong removed the return type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're a star ⭐
Summary
Upgrading to latest versions of
@web5
packages (dids, common, crypto, credentials)Removed dependency from
Jose
library inCrypto.ts
Using
DidResolver.dereference()
from@web5/dids
package, which closes #147Using
VerifiableCredentials.create()
from@web5/credentials
package instead ofDevTools.createCredential()
Part of an effort to break apart #126 into smaller ones. Related to #122