-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumping web5 versions #149
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7f56d82
bumping web5 versions. removed jwt related methods and credential met…
jiyoontbd c14d142
adding dht method to did creation devtool method
jiyoontbd 4d4923b
fixing crypto by comparing with main
jiyoontbd d7b4454
reverting changes to rfq spec
jiyoontbd bb173ff
reverting changes to crypto.spec.ts
jiyoontbd 9be2f9e
using didresolver from web5/dids
jiyoontbd ec69379
Use pre instantiated DidResolver
diehuxx eae295f
adding a changeset
jiyoontbd 025b95d
removing type in get required claims method
jiyoontbd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@tbdex/http-client": minor | ||
"@tbdex/protocol": minor | ||
--- | ||
|
||
Upgrading web5 versions in protocol and http-client |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,17 +50,21 @@ | |
}, | ||
"dependencies": { | ||
"@tbdex/protocol": "workspace:*", | ||
"@web5/common": "0.2.1", | ||
"@web5/crypto": "0.2.2", | ||
"@web5/dids": "0.2.2", | ||
"query-string": "8.1.0" | ||
"@web5/common": "0.2.2", | ||
"@web5/credentials": "0.4.1", | ||
"@web5/crypto": "0.2.4", | ||
"@web5/dids": "0.2.4", | ||
"ms": "2.1.3", | ||
"query-string": "8.1.0", | ||
"typeid-js": "0.3.0" | ||
}, | ||
"devDependencies": { | ||
"@playwright/test": "1.34.3", | ||
"@types/chai": "4.3.5", | ||
"@types/eslint": "8.37.0", | ||
"@types/mocha": "10.0.1", | ||
"@types/sinon": "^17.0.2", | ||
"@types/ms": "0.7.34", | ||
"@types/sinon": "17.0.1", | ||
"@typescript-eslint/eslint-plugin": "5.59.0", | ||
"@typescript-eslint/parser": "5.59.0", | ||
"chai": "4.3.10", | ||
|
@@ -78,7 +82,7 @@ | |
"mkdirp": "3.0.1", | ||
"mocha": "10.2.0", | ||
"rimraf": "4.4.0", | ||
"sinon": "15.0.2", | ||
"sinon": "17.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good catch, ty! |
||
"typedoc": "0.25.0", | ||
"typedoc-plugin-markdown": "3.16.0", | ||
"typescript": "5.2.2" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding
ms
andtypeid-js
tohttp-client
in this PR? Ifms
is necessary independencies
, why is@types/ms
indevDepencencies
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this PR is part of a 4 PR series in an effort to break down moe's 122-request-token PR which is a chonky boi.
i just ported over the client/package.json changes from the original PR, which includes ms and typeid-js since they're being used by the client during request token generation.
the PR that will use the ms and typeid-js is here
i thought we needed to include @types/xyz in devDependencies that correspond to package xyz in dependencies in order to write with type checking during development. is that incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, u right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yee that's correct @jiyoontbd