Update GitHub CI workflow to use Hermit dependencies #146, update Justfile cargo recipes to use entire workspace #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tfile cargo recipes to use entire workspace
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
|
Created #188 off of this to be completed at a later date, once we circle back to building out binded projects |
|
Created #189 to come back to at a later date, unblocking for now |
nitro-neal
approved these changes
May 9, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146
I also edited our
buildandtestjust recipes to span the entire workspace; this way we're also ensuring that thebindings/uniffiproject passes build & testAlso, I removed the
--releaseoption to thecargo buildcommand to improve performance (~13% improvement in build time); thejust buildrecipe is strictly for development purposes, not for building the release artifact (which will inevitably occur in the CI/CD pipeline, to be implemented at a later date)