perf/a11y: 슬라이드 인덱스 검색 개선 및 중복 ARIA 제거#327
Merged
Conversation
Co-authored-by: AndyH0ng <60703412+AndyH0ng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize slide search algorithm for better performance
perf/a11y: single-pass slide index lookup and remove duplicate tabpanel ARIA on mobile
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent issues in
SlidePage.tsx: redundant double array scan to resolve the current slide, and a mobile container incorrectly duplicating the desktoptabpanelARIA role/ID.Performance: single
findIndexinstead offind+findIndexAccessibility: remove duplicate tabpanel on mobile
The mobile
<div>hadrole="tabpanel"/id="tabpanel-slide-mobile"/aria-labelledby="tab-slide"— mirroring the desktop panel that's always in the DOM. Since only one is visible at a time via CSS, this created two elements claiming the same tab's content. The mobile div's ARIA tabpanel attributes are removed; the desktop panel retains them.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.