Skip to content

perf/a11y: 슬라이드 인덱스 검색 개선 및 중복 ARIA 제거 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyH0ng merged 2 commits into from
Mar 2, 2026
+10 −10
Merged

perf/a11y: 슬라이드 인덱스 검색 개선 및 중복 ARIA 제거 #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06df223
Initial plan
Copilot Mar 2, 2026
9e91dde
perf/a11y: optimize slide index search and fix duplicate ARIA tabpanel
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/pages/SlidePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,15 @@ export default function SlidePage() {
pollingIntervalMs: 15000,
});

const currentSlide = slides?.find((s) => s.slideId === routeSlideId) ?? slides?.[0];
const currentIndex = currentSlide
? (slides?.findIndex((s) => s.slideId === currentSlide.slideId) ?? -1)
: -1;
const currentIndexFromRoute = slides?.findIndex((s) => s.slideId === routeSlideId) ?? -1;
const effectiveIndex =
slides && slides.length > 0
? currentIndexFromRoute >= 0
? currentIndexFromRoute
: 0
: -1;
const currentSlide = effectiveIndex >= 0 && slides ? slides[effectiveIndex] : undefined;
const currentIndex = effectiveIndex;
const hasPrev = currentIndex > 0;
const hasNext = !!slides && currentIndex >= 0 && currentIndex < slides.length - 1;

Expand Down Expand Up @@ -132,12 +137,7 @@ export default function SlidePage() {
</main>
</div>

<div
role="tabpanel"
id="tabpanel-slide-mobile"
aria-labelledby="tab-slide"
className="flex min-[1024px]:hidden h-full flex-col px-4 py-4"
>
<div className="flex min-[1024px]:hidden h-full flex-col px-4 py-4">
<div className="flex items-center justify-between pb-3">
<button
type="button"
Expand Down