feat(TCOMP-2408): all causes of ComponentException are Exception.class #706
+278
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undx
reviewed
Apr 3, 2023
component-api/src/main/java/org/talend/sdk/component/api/exception/ComponentException.java
Outdated
Show resolved
Hide resolved
ypiel-talend
force-pushed
the
ypiel/TCOMP-2408_ComponentException_only_ExceptionCause
branch
from
34fdc82
to
661d858
Compare
undx
previously approved these changes
Jun 26, 2024
…' of [email protected]:Talend/component-runtime.git into ypiel/TCOMP-2408_ComponentException_only_ExceptionCause
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
undx
reviewed
Jul 3, 2024
| @@ -0,0 +1,2 @@ | |||
| = A tck sample Family | |||
There was a problem hiding this comment.
Used in the Test case, discussed with Axel, or, only used in test case, not commit?
component-api/src/main/java/org/talend/sdk/component/api/exception/ComponentException.java
Show resolved
Hide resolved
| componentException = new ComponentException(ComponentException.ErrorOrigin.USER, "message"); | ||
| Assertions.assertEquals(ComponentException.ErrorOrigin.USER, componentException.getErrorOrigin()); | ||
| } | ||
|
|
There was a problem hiding this comment.
You could also inspire you from InvocationExceptionWrapperTest class...
There was a problem hiding this comment.
Line 62-66 is hard to execute into...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
undx
reviewed
Aug 7, 2024
This comment has been minimized.
This comment has been minimized.
|
Analysis Details2 Issues
Coverage and Duplications
Project ID: org.talend.sdk.component:component-runtime |
acatoire
requested changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Why this PR is needed?
https://jira.talendforge.org/browse/TCOMP-2408
What does this PR adds (design/code thoughts)?
All cause exceptions are transformed to Exception.class to be known by all runtimes.