-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TCOMP-2408): all causes of ComponentException are Exception.class #706
Merged
yyin-talend
merged 26 commits into
master
from
ypiel/TCOMP-2408_ComponentException_only_ExceptionCause
Aug 14, 2024
Merged
Changes from 5 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
13ea702
feat(TCOMP-2408): all causes of ComponentException are Exception.class
ypiel-talend 661d858
feat(TCOMP-2408): check style fixe.
ypiel-talend 7b182dd
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
undx 0708142
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
yyin-talend ea27f5b
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
acatoire 498b27c
feat(TCOMP-2408): fix junit fails, and create a connector to validate it
yyin-talend 7e9b3e9
Merge branch 'ypiel/TCOMP-2408_ComponentException_only_ExceptionCause…
yyin-talend 7ce5256
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
yyin-talend b01d986
feat(TCOMP-2408): fix sonars
yyin-talend 4e8cea2
feat(TCOMP-2408):add more junit cases
yyin-talend 63ad550
feat(TCOMP-2408):change icon and make car available
yyin-talend b8f453b
feat(TCOMP-2408): add description in readme
yyin-talend 4517ab4
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
yyin-talend 448c727
Update README.adoc
acatoire a2a0f5a
feat(TCOMP-2408): remove TODOs in doc
yyin-talend aa5557c
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
yyin-talend ab290db
feat(TCOMP-2408): bump to M6
yyin-talend e178001
feat(TCOMP-2408):skip sonar on test connector
yyin-talend 3522c12
revert feat(TCOMP-2408):skip sonar on test connector for test
acatoire fe16809
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
acatoire beee830
feat(TCOMP-2408): remove the new connector in sample-parent
yyin-talend c7aa08a
feat(TCOMP-2408):integrate the test into sample-connector
yyin-talend 2c4027d
feat(TCOMP-2408): integration
yyin-talend a7ce05a
feat(TCOMP-2408):remove icon
yyin-talend fd40b0f
Merge branch 'master' into ypiel/TCOMP-2408_ComponentException_only_E…
yyin-talend eabfc8d
feat(TCOMP-2408):fix sonar
yyin-talend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
...nent-api/src/test/java/org/talend/sdk/component/api/exception/ComponentExceptionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/** | ||
* Copyright (C) 2006-2023 Talend Inc. - www.talend.com | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.talend.sdk.component.api.exception; | ||
|
||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.junit.jupiter.api.Assertions.*; | ||
|
||
class ComponentExceptionTest { | ||
|
||
@Test | ||
public void testTypedCauseExceptionTransformation() { | ||
IndexOutOfBoundsException indexOutOfBoundsException = new IndexOutOfBoundsException("AAA"); | ||
IllegalArgumentException illegalArgumentException = | ||
new IllegalArgumentException("BBB", indexOutOfBoundsException); | ||
IllegalStateException illegalStateException = new IllegalStateException("CCC", illegalArgumentException); | ||
|
||
ComponentException componentException = new ComponentException("DDD", illegalStateException); | ||
|
||
Throwable ccc = componentException.getCause(); | ||
Assertions.assertEquals(Exception.class, ccc.getClass()); | ||
|
||
Throwable bbb = ccc.getCause(); | ||
Assertions.assertEquals(Exception.class, bbb.getClass()); | ||
|
||
Throwable aaa = bbb.getCause(); | ||
Assertions.assertEquals(Exception.class, aaa.getClass()); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also inspire you from InvocationExceptionWrapperTest class...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 62-66 is hard to execute into...