CLAP-205 로그인 관련 API 연결 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minkyu0424
reviewed
Feb 2, 2025
Minkyu0424
reviewed
Feb 2, 2025
Minkyu0424
reviewed
Feb 2, 2025
Minkyu0424
reviewed
Feb 2, 2025
Minkyu0424
reviewed
Feb 2, 2025
Minkyu0424
approved these changes
Feb 2, 2025
Contributor
Minkyu0424
left a comment
Minkyu0424
left a comment
There was a problem hiding this comment.
고생하셨습니다 로그인 스웨거로 하느라 불편했는데 대환영입니다
seorang42
approved these changes
Feb 2, 2025
src/api/auth.ts
Outdated
| } | ||
| }) | ||
|
|
||
| Cookies.set('accessToken', response.data.accessToken, { |
Contributor
There was a problem hiding this comment.
혹시 순수 js를 사용하여 쿠키를 저장하고 사용하지 않고
js-cookie 라이브러리를 사용하시게 된 이유가 있을까요?
Member
Author
There was a problem hiding this comment.
우선 vue-cookies나 순수 js를 사용한 쿠키보다 보안 안정성 측면과 TypeScript 지원을 보았을때에도 js-cookie 라이브러리가 우수하다고 알고 있습니다. 또한 추후 토큰 변경 감지를 위한 watchEffect 를 사용할 것을 염두하여 선택하였습니다!
더 나아가면 개발자가 편하려고 사용하는 것은 이유가 되지 않지만, 사용하기 매우 편하다는 장점도 있습니다😳
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 티켓 넘버
📝작업 내용
🏞️스크린샷 (선택)
💬리뷰 요구사항(선택)