-
Notifications
You must be signed in to change notification settings - Fork 0
CLAP-205 로그인 관련 API 연결 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
09dd262
✨ [feat] : 로그인 API 연결
BaekJiyeon02 89d9fa7
✨ [feat] : 액세스 토큰 쿠키에 저장
BaekJiyeon02 0f024ee
✨ [feat] : 로그인 시 각 역할마다 경로 지정
BaekJiyeon02 d8712e2
✨ [feat] : Pinia 회원정보 저장하여 상태관리
BaekJiyeon02 c3ae5cd
✨ [feat] : Pinia에 저장된 회원정보 Top, Side에 적용
BaekJiyeon02 61c54f0
✨ [feat] : 비밀번호 재설정 API 연결
BaekJiyeon02 e512e46
♻️ [refactor] : 불필요한 코드 제거
BaekJiyeon02 45d3815
:sparkles: [feat] : 폼데이터 요청 api 형식 분리
Minkyu0424 61df8a1
:recycle: [refactor] : prop대신 직접 가져오기, 파일 초기값 배열로
Minkyu0424 11462ed
:recycle: [refactor] : 1,2차 카테고리 타입 선언 및 위치 변경
Minkyu0424 6a6b4a6
:sparkles: [feat] : 카테고리용 드롭다운 개별 생성
Minkyu0424 61ed646
:sparkles: [feat] : 1, 2차 카테고리 조회 api 연결
Minkyu0424 d1a8a41
:sparkles: [feat] : 요청 생성 api 연결
Minkyu0424 65b0f37
:sparkles: [feat] : 정보 누락시 경고 텍스트 출력
Minkyu0424 cd970aa
:sparkles: [feat] : 요청 완료 후 모달 및 라우팅
Minkyu0424 8c202cf
:recycle: [refactor] : axios instance 객체 분리해서 import
Minkyu0424 281050c
:recycle: [refactor] : 카테고리 드롭다운 placeholder없이, input placeholder 상수화 취소
Minkyu0424 9f952ae
♻️ [refactor] : axios 인스턴스 이슈 반영
BaekJiyeon02 f97d35b
:recycle: [refactor] : 1,2차 카테고리 타입 선언 및 위치 변경
Minkyu0424 c49d1fb
:sparkles: [feat] : 요청 생성 api 연결
Minkyu0424 d6b475b
:recycle: [refactor] : 1,2차 카테고리 타입 선언 및 위치 변경
Minkyu0424 81bb0ca
:sparkles: [feat] : 요청 생성 api 연결
Minkyu0424 6404730
♻️ [refactor] : 역할 변수에 따른 값 수정
BaekJiyeon02 f9d5023
Merge branch 'develop' into CLAP-205
BaekJiyeon02 1bb1826
♻️ [refactor] : 사용하지 않는 값 제거
BaekJiyeon02 9e76611
♻️ [refactor] : 토큰 axios파일에서 처리되므로 불필요하여 제거
BaekJiyeon02 6ccd304
♻️ [refactor] : 불필요한 예외처리 제거
BaekJiyeon02 de257f7
♻️ [refactor] : request body 추가 및 타입 선언
BaekJiyeon02 008fa11
♻️ [refactor] : 불필요 코드 제거
BaekJiyeon02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 순수 js를 사용하여 쿠키를 저장하고 사용하지 않고
js-cookie 라이브러리를 사용하시게 된 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우선 vue-cookies나 순수 js를 사용한 쿠키보다 보안 안정성 측면과 TypeScript 지원을 보았을때에도 js-cookie 라이브러리가 우수하다고 알고 있습니다. 또한 추후 토큰 변경 감지를 위한 watchEffect 를 사용할 것을 염두하여 선택하였습니다!
더 나아가면 개발자가 편하려고 사용하는 것은 이유가 되지 않지만, 사용하기 매우 편하다는 장점도 있습니다😳