Migrate newpipe.error to Kotlin #10922
Conversation
Only error was a nullable check in AcraReportSender, which I fixed by replacing null with an empty array. I tested the error report by producing a network error and opening the report, creating an email and accepting the EULA. Warnings will be fixed in the next commit.
We will init them at the beginning of the view lifecycle, so they are definitly not null.
|
There was a problem hiding this comment.
This class seems unused
There was a problem hiding this comment.
I think something went wrong with your review? The code you're talking about isn't showing up. Just the file names.
There was a problem hiding this comment.
Well yea, I wanted to point to the file name. AcraReportSender seems to be unused, I think the file is safe to remove instead of converting to Kotlin.
There was a problem hiding this comment.
Oh. I didn't know you could leave a review for an entire file.
There was a problem hiding this comment.
There are merge conflicts with this enum. Consider pulling the latest changes from dev and re-generate the .kt file
An experiment in how much effort it is to migrate classes to kotlin.
It took me about 30–60 minutes (minus getting to know some kotlin features) to migrate these, try the result and fix all warnings that popped up.
What is it?
Due diligence