Remove unused method in TimeAgoParser #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opusforlife2
added
the
codequality
* Dedup using parameterized tests * Make ``now`` controllable
litetex
force-pushed
the
TimeAgoParser-unused
branch
from
c06b873 to
746b36e
Compare
litetex
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM
Let's get this merged!
- Rebased branch
- Improved tests further
- Failing tests are unrelated
- Backported checkstyle fixes from Partial followup for #1262 #1263 as the build otherwise completely fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseDurationmethod inTimeAgoParser, as it was not being used anywhere in the extractor or NewPipe.TimeAgoParser.