Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial followup for #1262 #1263

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Partial followup for #1262 #1263

merged 2 commits into from
Jan 26, 2025

Conversation

litetex
Copy link
Member

@litetex litetex commented Jan 23, 2025

  • Fixed Checkstyle (Already merged via Remove unused method in TimeAgoParser #1212)
  • Use UncheckedIOException instead of RuntimeException as it's more specific
  • Use correct iPhone model in docs
  • Documentation has to be done by @Theta-Dev as I didn't write that code and have no deeper insight into this
  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

@litetex litetex changed the title Partial followup for 1262 Partial followup for #1262 Jan 23, 2025
@gechoto
Copy link
Contributor

gechoto commented Jan 24, 2025

yt-dlp updated the IOS client again: yt-dlp/yt-dlp#12155

I think this should be ported to NewPipeExtractor.
@litetex do you want to include it in this PR?

@litetex
Copy link
Member Author

litetex commented Jan 24, 2025

@litetex do you want to include it in this PR?

@gechoto
I think it would be better to have another PR, since this is kind of off-topic and I also can't review my own PRs ;)

@gechoto
Copy link
Contributor

gechoto commented Jan 26, 2025

@gechoto I think it would be better to have another PR, since this is kind of off-topic and I also can't review my own PRs ;)

okay after this is merged I can create another PR afterwards

@Stypox Stypox merged commit e0359ab into TeamNewPipe:dev Jan 26, 2025
3 of 4 checks passed
@litetex litetex deleted the followup-1262 branch January 27, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants