-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain questions cannot be answered because the cmd key is not override #32
Comments
Actually, cmd-h is not the only one. The question on "minimize window" also hides user's own window. (Cmd-M). |
Actually, make that rest of the question set, because none of the answer that require Cmd works. |
I think a solution @amychan331 would be to add |
@shiftyp Having indentation fix as a separate issue was actually talked about in #35, so I made another pull request for the indentation(#36). For some strange reason, when I merge the changes for indentation, #35 also merged. So I will probably create another pull request later... |
You're right, it's a bit tricker than that. I put together a JSFiddle with a solution, which involves preventing the keyDown event default when the meta or ctrl keys are engaged. You also need to prevent the keyPress. I found this stackOverflow particularly helpful in putting together a solution. |
Add next & previous buttons for commands which cannot be overridden. |
duplicate of #45 |
When users answer the "hide the window" question with Cmd-H, it will actually close user's own window, thus the practice would not precede to the next question. The Cmd-h needs to be override somehow.
The text was updated successfully, but these errors were encountered: