command hotkeys should be escaped instead of executed #45
Assignees
Labels
bug
Something isn't working
good first issue
Good for newcomers
GraceHopperOSD
Reserved for GHC Open Source Day!
Comments
alodahl
added
bug
|
I will look into fixing this! |
|
I have fixed this for a few of the command + key combinations, though some of them it seems like the browser won't let me override the keyboard shortcut. |
KatShambaugh
pushed a commit
to KatShambaugh/keyboard-shortcuts-practice
that referenced
this issue
Oct 1, 2020
alodahl
pushed a commit
that referenced
this issue
Oct 7, 2020
alodahl
added a commit
that referenced
this issue
Oct 30, 2021
* docs(contributing): move readme directions to own file (#61) * docs: Resolve a typo with commands (#87) * docs: test commit Co-authored-by: tilaprimera <[email protected]> * Resolves #65 - Finish ORM Setup (#91) * Fixes #65 - Finish ORM Setup - Ensure we can connect to the DB before launching Express - Use sqlite for normal dev mode; postgres for production - Upgrade sequelize and postgres npm packages since the versions we were using hung trying to connect to pg - Use the sequelize.sync functionality to automatically setup any table(s) * Allow either type of DB in development mode - in dev mode, have default DB_URL of sqlite - in prod, DB_URL must be specified * fix .gitignore to have correct sqlite db name * clean up package.json scripts * Fix port used in README and remove steps related to when the files were served by http-server (now using express) (#62) * orm.js updated with model for UserAnswers * updates to UserAnswers model * 34 caps lock toggle (#98) * fixed caps lock sync issue, capslock on is a keydown and capslock off is a keyup event * deleted unecesseray if condition in handle function for capslock * docs: add step for PR description * Replace repetitive if blocks with lookup * Remove unneeded files (#107) * Added post endpoint to save an user answer * refactor: Remove jQuery when possible (#109) * Replaced jQuery DOM Selectors with in-built one * return res object in handlers * added backend call when the answer is correct * solved merge conflict * fix: Add defer to script elements for better loading experience (#113) * fixed mistake with site url * added find by user_id validation * deleted autoincrement config on UserAnswers model * installing express-openid-connecyt * updating the README with instructions for Auth0 * integrating Auth0 middleware into server * Revert "refactor: Remove jQuery when possible (#109)" This reverts commit 9c9d786. * Add cross-env package for processing env variables in any platform (#112) Co-authored-by: Paul Diaz Navarrete <[email protected]> * Replacing Jquery with Fetch in main.js(#114) * feat: add shortcut type tag to JSON object and main screen (#103) * Addressing code review comments * Replace jQuery.text function * fixed issues with in-built DOM selector * remove window height listener in favour of css container height value from 800px to 100vh remove unneeded window height listener container height is already set by the css value * feat: add toggle to show/hide button hint (#127) * Updated ecstatic to v 4.1.4 (#126) * get last 3 timing given the user and question id endpoint * - integrated history endpoint - param in query instead of body in endpoint request * refactored history.js * fix: split list keyboard per row (#134) change styles to avoid breaks per row * fix: Command hotkeys escaped instead of executed #45 (#118) * Refactor the jquery functions in main.js * Resolving problems * Add highlight for Fn key in case F1-F12 is pressed. Fixes #29 * fixed all the comments made in review stage * Fixes #29. Add Fn un-highlight on release F1-12 * Fixes #29. Change jQuery to native DOM functions. Move macVSCode shortcut to the end. * added mock userId on the server * Added favicon Used serve-icon middleware to serve favicon. * Fixes #138. Add clear prompt for all hint keys (#139) * Resolve problem with keys that are not used, remove a comment * App can use Auth0 or local dev auth (#133) * Fixes #74 - fake login/logout for local dev - refactor auth setup so it is the same for the rest of the code regardless if it's fake dev or Auth0 - use express-session with sequelize store to handle sessions (they will persist dev reload) - add dummy login state message to bottom of index page so dev can use login/logout before buttons are added * make .env.example a little more user-friendly * add .git.local ignore so it can be used to switch between Auth0 and local dev without accidentally checking it in * Fully integrate Auth0 and local dev - Auth create user upon login or root request - Protect all /user API routes to need a valid signed-in user or they will respond with 401 - fix ORM data models so they have default values and work correctly with postgres * fix comments * Add Auth0 callback instructions (#141) * Add indexes: user_answers_created_at_user_id_question_number, user_answers_created_at_user_id * Integrate all auth-dependent API stories into working app version (#142) * Fixes #74 - fake login/logout for local dev - refactor auth setup so it is the same for the rest of the code regardless if it's fake dev or Auth0 - use express-session with sequelize store to handle sessions (they will persist dev reload) - add dummy login state message to bottom of index page so dev can use login/logout before buttons are added * make .env.example a little more user-friendly * add .git.local ignore so it can be used to switch between Auth0 and local dev without accidentally checking it in * Fully integrate Auth0 and local dev - Auth create user upon login or root request - Protect all /user API routes to need a valid signed-in user or they will respond with 401 - fix ORM data models so they have default values and work correctly with postgres * fix comments * do not save or fetch data unless logged in * fix get history endpoint to lookup by logged in user id from request * Implements #77 - replaces all localStorage lookups with saved /user/progress API call - remove commented code - add const/let variable declarations when missing * Add API integration specs using jasmine + supertest * Bump ini from 1.3.5 to 1.3.8 (#145) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Login button shows correct status centered (#146) * - Add login and logout buttons to the top of the main page * - Adjust account-info's margins * - 2nd draft of login button. Account info is centered in the whitespace above the read container Co-authored-by: Jackie Zhang <[email protected]> * Bump jose from 2.0.2 to 2.0.5 (#148) Co-authored-by: Josseline Perdomo <[email protected]> Co-authored-by: Sraddhanjali Acharya <[email protected]> Co-authored-by: tilaprimera <[email protected]> Co-authored-by: Bill DePhillips <[email protected]> Co-authored-by: Ambika Sadhu <[email protected]> Co-authored-by: ashley-g <[email protected]> Co-authored-by: Nadya Djojosantoso <[email protected]> Co-authored-by: Sergio Moreno Baeza <[email protected]> Co-authored-by: Josseline Perdomo <[email protected]> Co-authored-by: David Stroud <[email protected]> Co-authored-by: Aryan Verma <[email protected]> Co-authored-by: racheltl <[email protected]> Co-authored-by: Izzy Berzsenyi <[email protected]> Co-authored-by: Paúl Díaz Navarrete <[email protected]> Co-authored-by: Paul Diaz Navarrete <[email protected]> Co-authored-by: Astha Upadhyay <[email protected]> Co-authored-by: Beleicia Bullock <[email protected]> Co-authored-by: Linh <[email protected]> Co-authored-by: frankyfrankfrank <[email protected]> Co-authored-by: Dimitrij Agal <[email protected]> Co-authored-by: Anurag sati <[email protected]> Co-authored-by: Mayra Lucia Navarro <[email protected]> Co-authored-by: Kat Shambaugh <[email protected]> Co-authored-by: Ybrahin Martinez <[email protected]> Co-authored-by: Oleksandra <[email protected]> Co-authored-by: Nidhish <[email protected]> Co-authored-by: Oleksandra <[email protected]> Co-authored-by: Jackie Zhang <[email protected]> Co-authored-by: Jackie Zhang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cmd+t
cmd+n
cmd+shift+esc
cmd+space
cmd+tab
cmd+shift+~
cmd+shift+3
hotkeys should be escaped. Right now they are executed and interfere with the program.
potential solutions have been discussed in issue #32
Update: This was partially addressed in #118 , with these exceptions:
"Fixed for some key combinations; could not overwrite in Safari for command + n, command + m, command + t, command + w. I also tested in Chrome and at least command + n was still not working. Seems like it might be a browser issue with not allowing me to catch those events and override them. In my research I came across this library which may be able to help: https://craig.is/killing/mice."
The text was updated successfully, but these errors were encountered: