Fixes #66 added user/progress mock endpoint #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegetabill
requested changes
Oct 5, 2020
Comment on lines
+65
to
+67
| $('.container').css('height', $(window).height()); | ||
| $(window).on('resize', function () { | ||
| $('.container').css('height', $(window).height()); |
There was a problem hiding this comment.
These lines were deleted in a merge, but git must not have detected it, so please remove from this PR.
Comment on lines
+49
to
+52
| if (!response.ok) { | ||
| const message = `An error has occured: ${response.status}`; | ||
| console.error(message) | ||
| return 1 |
There was a problem hiding this comment.
Not sure if you missed the other PR comment but the return 1 won't work because the next step is expecting a userProgress object
|
Hi @ayushjain94 did you have a chance to look at the last review for this? |
|
Closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new pull request as I made a force push in previous PR and it got closed. I have incorporated all the changes suggested in the reviews.
closes #66