Skip to content

fix(Popup): avoid repeatedly triggering updateScrollTop #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uyarn merged 6 commits into from
Jan 16, 2026
+13 −3
Merged

fix(Popup): avoid repeatedly triggering updateScrollTop #4062

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd37825
fix(Popup): avoid repeatedly triggering `updateScrollTop` when the st…
RylanBot Jan 6, 2026
6cad2d6
chore: stash changelog [ci skip]
tdesign-bot Jan 6, 2026
cd89c91
fix(Popup): arrow position not correct when content is dynamic
RylanBot Jan 7, 2026
9047c47
chore: update changelog
RylanBot Jan 7, 2026
5cee759
fix: initial `updateScrollTop` failed
RylanBot Jan 15, 2026
36d04fe
fix: `updateScrollTop`
RylanBot Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/components/popup/Popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ import { getTransitionParams } from './utils/transition';

import type { PopupInstanceFunctions, TdPopupProps } from './type';

/**
* @internal
*/
export interface PopupProps extends TdPopupProps {
// 是否触发展开收起动画，内部下拉式组件使用
expandAnimation?: boolean;
Expand Down Expand Up @@ -217,7 +220,7 @@ const Popup = forwardRef<PopupInstanceFunctions, PopupProps>((originalProps, ref
});
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [visible, popupElement, updateScrollTop]);
}, [visible, popupElement]);

function handleExited() {
setIsOverlayHover(false);
Expand Down
Loading