est: create via resistors in series between tree and pin nodes #8426
Conversation
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
…e same layer Signed-off-by: Eder Monteiro <[email protected]>
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
…ROAD into est_via_res Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| int max_index = -1; | ||
| for (int i = 0; i < branchCount(); i++) { | ||
| const stt::Branch& branch_pt = tree_.branch[i]; | ||
| max_index = std::max(max_index, i); |
There was a problem hiding this comment.
warning: no header providing "std::max" is directly included [misc-include-cleaner]
src/est/src/SteinerTree.cpp:5:
- #include <cmath>
+ #include <algorithm>
+ #include <cmath>| for (int i = 0; i < branchCount(); i++) { | ||
| const stt::Branch& branch_pt = tree_.branch[i]; | ||
| max_index = std::max(max_index, i); | ||
| max_index = std::max({max_index, branch_pt.n}); |
There was a problem hiding this comment.
warning: no header providing "std::max" is directly included [misc-include-cleaner]
max_index = std::max({max_index, branch_pt.n});
^Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
…ROAD into est_via_res Signed-off-by: Eder Monteiro <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I'll close this PR, rebase it locally and start a new secure-CI for it. I'll create a new PR once the CI is stable with these changes. |
2 participants
Fixes #8408.
Vias were being added directly to the tree node, making the connection in parallel instead of in series, as it would be expected for via connections. This PR changes how they are created by adding extra nodes in the middle of the connection.
Also, this PR has a fix for pins above the tree layer. They would not be properly connected due to the assumption that all pins were below the tree layer.