Moved platform-specific WWKeyboardClass code into their own classes and files. #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isojalka
force-pushed
the
wwkeyboard_abstraction
branch
from
18ef244
to
971690c
Compare
isojalka
force-pushed
the
wwkeyboard_abstraction
branch
from
971690c
to
26d29ed
Compare
OmniBlade
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new functionality is introduced with this pull request. It simply abstracts the WWKeyboardClass interface and moves existing code into platform-specific files, to avoid hard-to-maintain #ifdef blocks in the main file.
Please note that this commit is more than a year old at this point. I did test these changes back then for all platforms, and I briefly retested them just now with SDL2 and SDL1 on Linux. I'd appreciate it if someone who uses Vanilla Conquer on Windows could test this and confirm that it also still works there.