Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pragma warning(disable) is only valid for MSVC #981

Closed
wants to merge 1 commit into from

Conversation

th-otto
Copy link
Contributor

@th-otto th-otto commented Mar 24, 2024

No description provided.

@OmniBlade
Copy link
Contributor

I'd be inclined to remove them entirely from the code base as they are MSVC only and you can turn off warnings from the command line on newer MSVC anyhow.

@th-otto
Copy link
Contributor Author

th-otto commented Mar 27, 2024

I agree, but that is currently not done in the CI builds and/or in CMakeLists.txt, and i did not want do break those builds or clutter them suddenly with lots of warnings.

If you want me to change it to entirely remove them, pls let me know.

@OmniBlade
Copy link
Contributor

#746 is intended to move the configuration of warnings out to a preset file that is used for the CI builds which would then allow removing these pragmas from the code base, but its very old as I'm not keen on just merging my own work without having it looked over by another maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants