Skip to content

bugfix(audio): Fix particle cannon being inaudible after saveload #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 5 commits into from
Feb 28, 2026
Merged

bugfix(audio): Fix particle cannon being inaudible after saveload #2302

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d22e2e
bugfix(audio): Fix particle cannon being inaudible after saveload
stephanmeesters Feb 13, 2026
169ce11
Reevaluate code based on table of results, add code for some more pre…
stephanmeesters Feb 14, 2026
fdbc5c8
Add old xfer version requirement, update comment to clarify retail co…
stephanmeesters Feb 25, 2026
c3e23a7
Apply suggestion from @greptile-apps[bot]
stephanmeesters Feb 25, 2026
63f3646
Replicate to Generals
stephanmeesters Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/ParticleUplinkCannonUpdate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,4 +1559,20 @@ void ParticleUplinkCannonUpdate::loadPostProcess( void )
}
}

// TheSuperHackers @info stephanmeesters 13/02/2026
Comment thread
stephanmeesters marked this conversation as resolved.
Outdated
// Fix issue where sound from the particle cannon is not audible after saveload
if( m_status == STATUS_FIRING || m_status == STATUS_POSTFIRE || m_status == STATUS_PACKING )
Comment thread
xezon marked this conversation as resolved.
Outdated
{
if( m_firingToIdleSound.getEventName().isNotEmpty() )
{
m_firingToIdleSound.setObjectID( getObject()->getID() );
m_firingToIdleSound.setPlayingHandle( TheAudio->addAudioEvent( &m_firingToIdleSound ) );
}
if( m_orbitToTargetBeamID != INVALID_DRAWABLE_ID && m_annihilationSound.getEventName().isNotEmpty() )
{
m_annihilationSound.setDrawableID( m_orbitToTargetBeamID );
m_annihilationSound.setPlayingHandle( TheAudio->addAudioEvent( &m_annihilationSound ) );
}
}

}
Loading