Skip to content

bugfix(radar): Fix incorrect 2D distance calculation in Radar::tryEvent #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 5 commits into from
Mar 3, 2026
Merged

bugfix(radar): Fix incorrect 2D distance calculation in Radar::tryEvent #2368

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7c79bc7
bugfix(radar): Fix incorrect 2D distance calculation in Radar::tryEvent
johnneijzen Feb 28, 2026
0ddd87b
Use const for distance calculation variables
johnneijzen Feb 28, 2026
e79acf4
Merge branch 'TheSuperHackers:main' into fix_radar_event_distance_squ…
johnneijzen Mar 3, 2026
d086419
use one line solution instead
johnneijzen Mar 3, 2026
80bbb16
Fix formatting issue in Radar.cpp
johnneijzen Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Core/GameEngine/Source/Common/System/Radar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,8 +1186,9 @@ Bool Radar::tryEvent( RadarEventType event, const Coord3D *pos )
{

// get distance from our new event location to this event location in 2D
Real distSquared = m_event[ i ].worldLoc.x - pos->x * m_event[ i ].worldLoc.x - pos->x +
Comment thread
johnneijzen marked this conversation as resolved.
m_event[ i ].worldLoc.y - pos->y * m_event[ i ].worldLoc.y - pos->y;
const Real dx = m_event[i].worldLoc.x - pos->x;
const Real dy = m_event[i].worldLoc.y - pos->y;
Comment thread
Caball009 marked this conversation as resolved.
Outdated
const Real distSquared = dx * dx + dy * dy;

if( distSquared <= closeEnoughDistanceSq )
{
Expand Down
Loading