Skip to content

tweak: decouple GUI window-move animations from the render frame rate #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobtista wants to merge 4 commits into
base: main
Choose a base branch
from
Open

tweak: decouple GUI window-move animations from the render frame rate #2833

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a40483a
tweak: decouple GUI window-move animations from the render frame rate
bobtista Jun 27, 2026
e829b80
tweak: decouple GUI window-move animations from the render frame rate…
bobtista Jun 27, 2026
c240eba
tweak: use frame pacer ratio for animation pacing and pump the manage…
bobtista Jul 8, 2026
9e1972c
tweak: use frame pacer ratio for animation pacing and pump the manage…
bobtista Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Generals/Code/GameEngine/Include/GameClient/AnimateWindowManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,13 @@ class AnimateWindowManager : public SubsystemInterface
Bool isReversed(); ///< Returns whether or not we're in our reversed state.
Bool isEmpty();
private:
void step(); ///< Runs a single base-rate step of all registered window animations

AnimateWindowList m_winList; ///< A list of AnimationWindows that we don't care if their finished animating
AnimateWindowList m_winMustFinishList; ///< A list of AnimationWindows that we do care about
Bool m_needsUpdate; ///< If we're done animating all our monitored windows, then this will be false
Bool m_reverse; ///< Are we in a reverse state?
Real m_updateAccumulator; ///< Carries fractional base-rate steps between updates
ProcessAnimateWindowSlideFromRight *m_slideFromRight; ///< Holds the process in which the windows slide from the right
ProcessAnimateWindowSlideFromRightFast *m_slideFromRightFast;
ProcessAnimateWindowSlideFromTop *m_slideFromTop; ///< Holds the process in which the windows slide from the Top
Expand Down
26 changes: 26 additions & 0 deletions Generals/Code/GameEngine/Source/GameClient/GUI/AnimateWindowManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#include "GameClient/GameWindow.h"
#include "GameClient/Display.h"
#include "GameClient/ProcessAnimateWindow.h"
#include "Common/FramePacer.h"
//-----------------------------------------------------------------------------
// DEFINES ////////////////////////////////////////////////////////////////////
//-----------------------------------------------------------------------------
Expand Down Expand Up @@ -133,6 +134,7 @@ AnimateWindowManager::AnimateWindowManager()
m_winList.clear();
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
m_winMustFinishList.clear();
}
AnimateWindowManager::~AnimateWindowManager()
Expand All @@ -159,6 +161,7 @@ void AnimateWindowManager::init()
clearWinList(m_winMustFinishList);
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
}

void AnimateWindowManager::reset()
Expand All @@ -168,9 +171,32 @@ void AnimateWindowManager::reset()
clearWinList(m_winMustFinishList);
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
}

// TheSuperHackers @tweak bobtista 27/06/2026 Decouple GUI window-move animations from the render frame rate
void AnimateWindowManager::update()
{
Real deltaSeconds = TheFramePacer->getUpdateTime();

// Clamp the delta so a long stall (load, alt-tab) cannot snap an animation to its end.
const Real maxCatchUpSeconds = 0.2f;
if (deltaSeconds > maxCatchUpSeconds)
{
deltaSeconds = maxCatchUpSeconds;
}

m_updateAccumulator += deltaSeconds * (Real)BaseFps;
Int steps = (Int)m_updateAccumulator;
m_updateAccumulator -= (Real)steps;

while (steps-- > 0)
{
step();
}
}

void AnimateWindowManager::step()
{

ProcessAnimateWindow *processAnim = nullptr;
Expand Down
3 changes: 3 additions & 0 deletions GeneralsMD/Code/GameEngine/Include/GameClient/AnimateWindowManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,13 @@ class AnimateWindowManager : public SubsystemInterface
Bool isReversed(); ///< Returns whether or not we're in our reversed state.
Bool isEmpty();
private:
void step(); ///< Runs a single base-rate step of all registered window animations

AnimateWindowList m_winList; ///< A list of AnimationWindows that we don't care if their finished animating
AnimateWindowList m_winMustFinishList; ///< A list of AnimationWindows that we do care about
Bool m_needsUpdate; ///< If we're done animating all our monitored windows, then this will be false
Bool m_reverse; ///< Are we in a reverse state?
Real m_updateAccumulator; ///< Carries fractional base-rate steps between updates
ProcessAnimateWindowSlideFromRight *m_slideFromRight; ///< Holds the process in which the windows slide from the right
ProcessAnimateWindowSlideFromRightFast *m_slideFromRightFast;
ProcessAnimateWindowSlideFromTop *m_slideFromTop; ///< Holds the process in which the windows slide from the Top
Expand Down
26 changes: 26 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/AnimateWindowManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
#include "GameClient/GameWindow.h"
#include "GameClient/Display.h"
#include "GameClient/ProcessAnimateWindow.h"
#include "Common/FramePacer.h"
//-----------------------------------------------------------------------------
// DEFINES ////////////////////////////////////////////////////////////////////
//-----------------------------------------------------------------------------
Expand Down Expand Up @@ -133,6 +134,7 @@ AnimateWindowManager::AnimateWindowManager()
m_winList.clear();
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
m_winMustFinishList.clear();
}
AnimateWindowManager::~AnimateWindowManager()
Expand All @@ -159,6 +161,7 @@ void AnimateWindowManager::init()
clearWinList(m_winMustFinishList);
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
}

void AnimateWindowManager::reset()
Expand All @@ -168,9 +171,32 @@ void AnimateWindowManager::reset()
clearWinList(m_winMustFinishList);
m_needsUpdate = FALSE;
m_reverse = FALSE;
m_updateAccumulator = 0.0f;
Comment thread
bobtista marked this conversation as resolved.
Outdated
}

// TheSuperHackers @tweak bobtista 27/06/2026 Decouple GUI window-move animations from the render frame rate
void AnimateWindowManager::update()
{
Real deltaSeconds = TheFramePacer->getUpdateTime();

// Clamp the delta so a long stall (load, alt-tab) cannot snap an animation to its end.
const Real maxCatchUpSeconds = 0.2f;
Comment thread
bobtista marked this conversation as resolved.
Outdated
if (deltaSeconds > maxCatchUpSeconds)
{
deltaSeconds = maxCatchUpSeconds;
}

m_updateAccumulator += deltaSeconds * (Real)BaseFps;
Comment thread
bobtista marked this conversation as resolved.
Outdated
Int steps = (Int)m_updateAccumulator;
m_updateAccumulator -= (Real)steps;

while (steps-- > 0)
{
step();
}
}

void AnimateWindowManager::step()
{

ProcessAnimateWindow *processAnim = nullptr;
Expand Down
Loading