Skip to content

fix(displaystring): Guard null bold font pointer in W3DDisplayString::setFont() #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 3 commits into from
Jul 28, 2026
Merged

fix(displaystring): Guard null bold font pointer in W3DDisplayString::setFont() #2893

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91608dd
fix(w3d): guard against null bold font in W3DDisplayString::setFont
bobtista Jul 19, 2026
c99e3a8
fix(w3d): replicate null bold font guard to Generals
bobtista Jul 19, 2026
b3227a3
fix(w3d): Simplify null bold font guard
bobtista Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplayString.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,12 @@ void W3DDisplayString::setFont( GameFont *font )
// set the font in our renderer
m_textRenderer.Set_Font( static_cast<FontCharsClass *>(m_font->fontData) );

m_textRendererHotKey.Set_Font( static_cast<FontCharsClass *>(TheFontLibrary->getFont(font->nameString,font->pointSize, TRUE)->fontData) );
// TheSuperHackers @fix bobtista 19/07/2026 Guard against null bold font to prevent crash when font loading fails
Comment thread
bobtista marked this conversation as resolved.
Outdated
GameFont *boldFont = TheFontLibrary->getFont( font->nameString, font->pointSize, TRUE );
if( boldFont != nullptr )
Comment thread
bobtista marked this conversation as resolved.
Outdated
{
m_textRendererHotKey.Set_Font( static_cast<FontCharsClass *>(boldFont->fontData) );
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
// recompute extents for text with new font
computeExtents();

Expand Down
7 changes: 6 additions & 1 deletion GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplayString.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,12 @@ void W3DDisplayString::setFont( GameFont *font )
// set the font in our renderer
m_textRenderer.Set_Font( static_cast<FontCharsClass *>(m_font->fontData) );

m_textRendererHotKey.Set_Font( static_cast<FontCharsClass *>(TheFontLibrary->getFont(font->nameString,font->pointSize, TRUE)->fontData) );
// TheSuperHackers @fix bobtista 19/07/2026 Guard against null bold font to prevent crash when font loading fails
GameFont *boldFont = TheFontLibrary->getFont( font->nameString, font->pointSize, TRUE );
if( boldFont != nullptr )
{
m_textRendererHotKey.Set_Font( static_cast<FontCharsClass *>(boldFont->fontData) );
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
// recompute extents for text with new font
computeExtents();

Expand Down
Loading