bugfix(behavior): Do not fire weapons via the InstantDeathBehavior module while under construction

[Stubbjax]

This change prevents weapons from being fired via the InstantDeathBehavior module if the OBJECT_STATUS_UNDER_CONSTRUCTION status is set.

This behaviour is already inherent to the FireWeaponWhenDeadBehavior module, and behaviour is now consistent between both modules as a result.

Retail data relies on this inherent condition - note ChinaPowerPlant does not fire its death weapon when destroyed/cancelled while under construction, despite lacking an ExemptStatus = UNDER_CONSTRUCTION field:

Object ChinaPowerPlant
  Behavior = FireWeaponWhenDeadBehavior ModuleTag_XX
    DeathWeapon = ChinaPowerPlantDeathWeapon
    StartsActive = YES
  End
End

However, when utilising the InstantDeathBehavior module, this inherent condition no longer applies and the weapon is fired when destroyed/cancelled while under construction:

Object ChinaPowerPlant
  Behavior = InstantDeathBehavior ModuleTag_XX
    Weapon = ChinaPowerPlantDeathWeapon
  End
End

This deviation between behaviours is not visible nor intuitive. An alternative approach would be to remove the inherent condition entirely from both modules and rely on the data-driven ExemptStatus. However, this would break retail data and likely cause unnecessary additional work for modders; there is unlikely to ever be a situation where a scaffold should fire a weapon upon destruction/cancellation.

[greptile-apps]

Greptile Summary

Prevents InstantDeathBehavior from firing configured weapons for objects marked under construction in non-retail-compatible builds.

• Applies the same weapon-firing guard to the Generals and Zero Hour implementations.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp	Adds the under-construction weapon suppression to the Generals behavior implementation.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/InstantDeathBehavior.cpp	Mirrors the under-construction weapon suppression in the Zero Hour behavior implementation.

_{Reviews (2): Last reviewed commit: "bugfix: Do not fire weapons via the Inst..." | Re-trigger Greptile}